lukeweber / webrtc-jingle-client

Webrtc audio + jingle protocol brought to IOS and Android.
https://groups.google.com/forum/?fromgroups#!forum/webrtc-jingle
BSD 3-Clause "New" or "Revised" License
335 stars 137 forks source link

Fix errors in unit tests #77

Open lukeweber opened 11 years ago

lukeweber commented 11 years ago

Following the instructions on README you can run unit tests. We should probably fix the errors that are occurring. This is only the tests from libjingle_unittests, there's still as well, p2p, and media unit tests.

Could be due to a patch for concurrency I put in thread shutdown. Maybe it shuts down differently now than previously was expected.

jni/../../../third_party/libjingle/talk/base/thread_unittest.cc:270: Failure Value of: signaled Actual: false Expected: true [ FAILED ] ThreadTest.Release (3009 ms)

Could be due to running on emulator: jni/../../../third_party/libjingle/talk/base/fileutils_unittest.cc:133: Failure Expected: (free3) > (0), actual: 0 vs 0

Most likely because we're missing ipv6 in jni/../../../third_party/libjingle/talk/base/network_unittest.cc:482: Failure Value of: ipv6_found Actual: false Expected: true