lukeweber / webrtc-jingle-client

Webrtc audio + jingle protocol brought to IOS and Android.
https://groups.google.com/forum/?fromgroups#!forum/webrtc-jingle
BSD 3-Clause "New" or "Revised" License
335 stars 137 forks source link

mips build doesn't work on final on ndk r8e #78

Open lukeweber opened 11 years ago

lukeweber commented 11 years ago

icf=safe doesn't seem to work for the mips linker.

Violating file: https://github.com/lukeweber/webrtc-jingle-client/blob/master/android/voice-client-core/jni/default_final.mk

Specifically, this doesn't seem to work. I've tested that TARGET_ARCH simply isn't defined in this file and it's only called once.

ifneq ($(TARGET_ARCH),mips) APP_LDFLAGS += -Wl,--icf=safe endif