lukeweber / webrtc-jingle-client

Webrtc audio + jingle protocol brought to IOS and Android.
https://groups.google.com/forum/?fromgroups#!forum/webrtc-jingle
BSD 3-Clause "New" or "Revised" License
335 stars 137 forks source link

remove temporary fix for libjingle, update clientsignalingthread.cc for mediasessionclient. #79

Closed lukeweber closed 11 years ago

lukeweber commented 11 years ago

We need to change the way we construct the mediasessionclient in both ios and android to match the latest and greatest from webrtc.

Example code here of what to do: https://github.com/lukeweber/libjingle-override/blob/master/talk/examples/call/callclient.cc

//sec settings sdespolicy(cricket::SEC_DISABLED), dtlspolicy(cricket::SEC_DISABLED), mediaclient->set_secure(sdespolicy);

//Session manager... ssl_identity.. should check this out. sessionmanager->set_secure(dtlspolicy); sessionmanager->set_identity(sslidentity.get()); sessionmanager->set_transport_protocol(transportprotocol);

///Just stuff that needs to be converted... if (!mediaengine) { mediaengine = cricket::MediaEngineFactory::Create(); }

if (!dataengine) { // TODO(pthatcher): Make it easy to make other types of data // engines. dataengine = new cricket::RtpDataEngine(); }

mediaclient = new cricket::MediaSessionClient( xmppclient->jid(), sessionmanager, mediaengine, dataengine, cricket::DeviceManagerFactory::Create());

I've temporarily enabled the old methods here, which need to be reverted once this is tested: https://github.com/lukeweber/libjingle-override/commit/ffe33c462ec11146d9e74766282345e13d9b6d38

lukeweber commented 11 years ago

Partially resolved with this commit. https://github.com/lukeweber/webrtc-jingle-client/commit/3d03edeba5691e6dff65c88c0d6a7801d1b16964