BUGFIX: Exception was being raised when add_to_PATH was not set

lukexi / stack-ide-sublime

An Sublime Text IDE for Haskell based on stack-ide

27 stars 5 forks source link

BUGFIX: Exception was being raised when add_to_PATH was not set #6

Closed jcpetruzza closed 9 years ago

jcpetruzza commented 9 years ago

Fixes #5.

We were logging the value of alt_env['PATH'] but alt_env could be None.

I also add better logging of exceptions when creating an instance, to ease diagnosing this kind of errors, and also ensure that the process field of a StackIDE is always defined (that was the cause of the error shown in StackIDE.__del__).

lukexi commented 9 years ago

Hahaha, we fixed it at the same time!

lukexi commented 9 years ago

I reverted my commit and grabbed yours since it did a couple other things, thanks : )

lukexi commented 9 years ago

Oh, and I added you as a collaborator so feel free to push directly now if you want!

jcpetruzza commented 9 years ago

Oh, cool, thanks!