lukin / keywind

Keywind is a component-based Keycloak Login Theme built with Tailwind CSS
Apache License 2.0
737 stars 261 forks source link

feat: email theme #55

Closed paulwer closed 3 weeks ago

paulwer commented 9 months ago

closes https://github.com/lukin/keywind/issues/47 references https://github.com/lukin/keywind/issues/6

Hey folks, ive managed a mailwind integration.

From my pov it may not be perfect, but it works as intended (for me). any thoughts on this?

I've created this theme based on the mailwind front-website example.

emails should be tested for visibility on the most used e-mail clients (help wanted):

paulwer commented 9 months ago

did someone want to check/help and give feedback for a client? @CHE1RON @lukin

paulwer commented 9 months ago

display on gmail Unbekannt

known issues:

CHE1RON commented 9 months ago

Looks promising! Never heard of Mailwind before, thanks!

paulwer commented 9 months ago

display on web.de Unbenannt known issues:

paulwer commented 9 months ago

@CHE1RON @lukin any other providers needed / wished / to be checked?

CHE1RON commented 9 months ago

I guess Gmail as de-facto standard is all that needs to be checked really 😅

CHE1RON commented 9 months ago

Don't get me wrong, privately I don't have a Gmail account - but nearly everyone I know has one ..

paulwer commented 9 months ago

outlook still doesnt looks great, i guess exspecialy for companies, this would be great to optimize at least -_-

CHE1RON commented 9 months ago

As far as my scarce experience with Outlook goes, fixing it is out of scope for keywind 😂

paulwer commented 9 months ago

i think checking on apple should be also a prio: 1689235958-most-used-email-clients-worldwide

(wold usage of mail clients from 2023 according to: Website

CHE1RON commented 9 months ago

Feel free to send emails to folkers [at] codefy [dot] de and I'll post screenshots 😉

paulwer commented 9 months ago

@CHE1RON you should have recieved an email yesterday :)

CHE1RON commented 9 months ago
Screenshot 2023-09-29 at 10 03 23

looks good 👍

paulwer commented 9 months ago

yahoo Unbenannt

known issues:

paulwer commented 9 months ago

as mentioned outlook still looks not good, i will try to come up with some changes to change this: Unbenannt

CHE1RON commented 9 months ago

@paulwer I mean it says right there in your screenshot: if it looks shitty, please view it in your browser 😂

paulwer commented 9 months ago

@CHE1RON I've sended you another e-mail, please check the formatting, outlook looks now better and the other platforms are still optical the same: Unbenannt

i changed the usage of div's to the table syntax for old email clients. i will commit, if this looks also good on apple :)

paulwer commented 9 months ago

outlook.com works like a charm Unbenannt

background images are now present on all platforms i tested. <3 (only outlook destop does not display it xD)

paulwer commented 9 months ago

thunderbird also works great <3 Unbenannt

android gmail and outlook tested as well and worked great. gmail does display it as dark mode variant, but its readable and approved from my pov.

paulwer commented 9 months ago

@lukin any test files needed for this PR?

CHE1RON commented 9 months ago

macOS Mail:

image

paulwer commented 9 months ago

@lukin this pr is ready to be merged

paulwer commented 9 months ago

within this PR, I used the mailwind logo as default logo. should we replace it with a keycloak logo to match a more "default" - alike look or remove the logo by default, to be fit with plain installation and maybe display just the realm name, if nothing is defined... I could also imagine a customization behavior within theme.properties, like mentioned in: #59

any opinions on that? @lukin @CHE1RON

CHE1RON commented 9 months ago

I see no apparent reason why keywind should propagate Mailwind by using its logo by default 🤔

No logo imho 👍

paulwer commented 9 months ago

@CHE1RON is right, the logo should be optional. Therefore i will push a commit with the mentioned themeLogoUrl as property of the theme shortly. if no url is provided the realmName as heading is used accordingly.

@lukin PR is ready again :)

paulwer commented 3 weeks ago

closed in favor for: https://github.com/lukin/keywind/pull/96