lukka / run-cmake

GitHub Action to build C++ applications with CMake (CMakePresets.json), Ninja and vcpkg on GitHub.
MIT License
171 stars 19 forks source link

Support package presets #107

Closed malaterre closed 1 year ago

malaterre commented 1 year ago

In issue #102 workflow preset support was added, but not package preset. Could you please add "packagePreset" support just like configurePreset/buildPreset.

ref:

thanks !

lukka commented 1 year ago

@malaterre good idea! Would you be able to provide a small sample of how it would be used? I need to add a sample like the workflow one: https://github.com/lukka/CppBuildTasks-Validation/blob/v10/.github/workflows/hosted-cmake-workflow.yml I haven't done my homework yet, and have these questions:

malaterre commented 1 year ago

Hi lukka !

Here is what I did:

      - name: Manual CPack preset step
        run: cpack --preset '${{ env.CMAKE_PRESET }}'

This is definitely an option of cpack. I have not read on worflow stuff yet, so I do not know.

HTH

lukka commented 1 year ago

@malaterre ok, go it. Would you mind testing this version suits your needs? lukka/run-cmake@dev/package-preset

malaterre commented 1 year ago

@lukka seems like I am missing something here:

lukka commented 1 year ago

@malaterre thanks for trying, I fixed it, you may try again.

malaterre commented 1 year ago

That worked out just fine:

Thanks !

lukka commented 1 year ago

Solved in #109