search

lukka / run-cmake

GitHub Action to build C++ applications with CMake (CMakePresets.json), Ninja and vcpkg on GitHub.
MIT License
181 stars 19 forks source link

Build output not visible during/after build when using a build preset #112

Closed vadi2 closed 1 year ago

vadi2 commented 1 year ago

The build output is not visible when using a build preset:

Screen recording 2023-05-14 3.34.25 PM.webm

Looking at the raw logs, it seems to be hidden inside the configure step.

This is not an issue when build presets aren't involved:

image

vadi2 commented 1 year ago

It's the same after a build is completed:

image

lukka commented 1 year ago

@vadi2 thanks for the report! Could you please provide a link to a workflow run where this happened? Also, it may be that you still have enabled the option --debug-find that probably is too verbose.

vadi2 commented 1 year ago

It's the workflow in https://github.com/Mudlet/Mudlet/pull/6772. Totally did have --debug-find enabled, thanks for that.

lukka commented 1 year ago

@vadi2 the problem I see by reading the log is that CMake cannot find the C++ compiler when configuring the projects. That means the project files to build are not generated (and the build does not start).

The reason is that run-cmake try to help the users setting up the environment for the given triplet by leveraging the vcpkg env command, but this is kind of not happening when the triplet is VCPKG_DEFAULT_TRIPLET: x64-mingw-dynamic, as shown here.

This usually works good to setup the environment for MSVC, but in this case vcpkg env does nothing good, and the PATH environment variable does not contain the path to the gcc.exe of mingw.

With run-cmake@v3, how the path to mingw compiler was found?

lukka commented 1 year ago

@vadi2 let me know if this is still an existing problem, closing this issue for now.