Support for annotations

lukka / run-cmake

GitHub Action to build C++ applications with CMake (CMakePresets.json), Ninja and vcpkg on GitHub.

MIT License

176 stars 19 forks source link

Support for annotations #17

Closed vadi2 closed 4 years ago

vadi2 commented 4 years ago

Would it be possible to support annotations with the action?

Any warnings right now are pretty hidden deep inside the workflow -> job -> vcpkg step -> run vcpkg.

Selection_564

Just a quality of life improvement.

lukka commented 4 years ago

@vadi2 this is a great suggestion indeed: is adding a problem matcher going to help? I think a different set of matchers could be enabled:

one set for CMake used at configuration time;
one used when building, this requires understanding which compiler is being used (i.e. msvc vs gcc/clang);

Is there any other set of matchers that could be added?

vadi2 commented 4 years ago

I believe that covers them all!

lukka commented 4 years ago

since the limitation of fromPath, the annotation for CMake works only if the CMakeLists.txt file is located on the root of the repository: https://github.com/actions/runner/issues/461

Unless I come up with a different solution, the CMake annotation could be enabled only when the CMakeLists.txt is in the root of the repo.

vadi2 commented 4 years ago

Sounds OK to me. Ours is at root: https://github.com/Mudlet/Mudlet