search

lukka / run-cmake

GitHub Action to build C++ applications with CMake (CMakePresets.json), Ninja and vcpkg on GitHub.
MIT License
176 stars 19 forks source link

'env' printed in Windows builds #34

Closed vadi2 closed 3 years ago

vadi2 commented 3 years ago

It seems that when using the action on Windows, env is printed: https://github.com/Mudlet/Mudlet/runs/1385861365?check_suite_focus=true

Selection_434

This does not happen under macOS or Linux. Perhaps not intended?

lukka commented 3 years ago

@vadi2 right, the output should be at least under an expandable section, as it may be annoying. As you correctly pointed out, it happens only on Windows when msvc is being used (it setups appropriately the Developer Command prompt using the vcpkg triplet).

I think it makes sense to put this verbose output under a collapsible log element indeed.

vadi2 commented 3 years ago

In my case I'm using MinGW, not msvc - from the same link:

Selection_435

But I think that's a minor detail.

lukka commented 3 years ago

fixed in run-cmake@v3