lukka / run-vcpkg

The GitHub Action to setup vcpkg for your C++ based projects. Stores built ports using Binary Caching backed onto GH Cache.
MIT License
196 stars 26 forks source link

default vcpkg install directory #212

Closed a-zakir closed 1 year ago

a-zakir commented 1 year ago

Hello, if env.VCPKG_INSTALLED_DIR is not set then the install command is: Running command D:\a\/\vcpkg\vcpkg.exe"' with args '^"install^",^"--recurse^",^"--clean-after-build^",^"--x-install-root^",^"D:/a//b/vcpkg_installed^",^"--triplet^",^"x64-windows^" would not be easier with --x-install-root = "D:/a///vcpkg_installed" or alongside the vcpkg.json manifest file? same question for binaryCachePath. OS : windows

thanks

lukka commented 1 year ago

@a-zakir I can imagine that the directory called b could be a problem, and I think I need you help: could you elaborate which improvements you are foreseeing? Thank you.

a-zakir commented 1 year ago

@lukka : Project_Root_dir : |_vcpkg/ |_vcpkg.json |_vcpkg_installed/ |_vcpkg_cache/ (could be in vcpkg_installed/ ??) See https://learn.microsoft.com/en-us/vcpkg/users/buildsystems/cmake-integration#vcpkg_installed_dir

a-zakir commented 1 year ago

I understand the problem is when run_vcpkg install packages before the CMake configure step (cmake_binary_dir not set yet). I think it's a vcpkg problem, telling cmake to look for dependencies in the right place

lukka commented 1 year ago

@a-zakir FYI in run-vcpkg@v11.3 the directory used for vcpkg artifacts it has been moved under the GITHUB_WORKSPACE. If you have any problem with the default location, let me know.