Closed eladm-ultrawis closed 1 year ago
@eladm-ultrawis please take a look to this C++ template project, it shows how to setup a C++ based repository with and without run-vcpkg/get/run-cmake actions, so you have two options at least: https://github.com/lukka/CppCMakeVcpkgTemplate
Note that the attachments in the previous comment are zero byte files, if you could re upload them I will certainly take a look.
@lukka I fixed the missing files - let me know if you want more verbose logs or something is missing.
regarding the template - I am pretty much following the same pattern (working with it for more then a year). The main difference is that I don't put vcpkg as a submodule within the directory. I usually install it on the system and have VCPKG_ROOT point to it. Could that be an issue?
Thanks!
@lukka to make it easier, I created a minimalistic project that reproduces the issue:
https://github.com/Ultrawis/cpp_project_template
you can simply fork it and run the single workflow that is there.
I appreciate any help with this!
@eladm-ultrawis thank you for creating a simple repro of the problem. Looks like one of the steps that I commented out is deleting the vcpkg repository downloaded prior with run-vpkg
. Look at this successful run (still ongoing, it passed after the point where the CMake's toolchain is being consumed:
https://github.com/lukka/cpp_project_template/actions/runs/6874365199/job/18695892552
@lukka I now moved the run-vcpkg stage to run just before run-cmake and indeed the toolchain is found by cmake. I wonder why the previous stages are messing with this folder. They are only supposed to restore the lfs files, not remove anything. anyway, I am closing this issue. THANKS AGAIN!
I have an existing workflow that uses all lukkas goodies - get-cmake, run-vcpkg and run-cmake.
It works locally when run with 'act' on 'ubuntu-22.04' / 'ubuntu-latest'.
This is the workflow file:
However, when I try to run it on an official github runner, running cmake --preset=<> fails:
This is even though the path seems correct, and VCPKG_ROOT is set correctly by run-vcpkg as far as I can see.
I don't know if this is an issue with run-vcpkg or something else entirely, but I was hoping to at least get a hint of what could possibly go wrong.
I added the logs for all the actions.
7_get cmake and ninja.txt 8_get vcpkg.txt 14_Run CMake consuming CMakePreset.json and run vcpkg to bui.txt