when there are either no up or down trains in the XML the exporter creates gibberish

lukos / simsig_importer

.Net Desktop Application for converting Excel simplified timetables into Simsig timetables

GNU General Public License v3.0

3 stars 1 forks source link

when there are either no up or down trains in the XML the exporter creates gibberish #38

Closed breadje closed 2 years ago

breadje commented 2 years ago

When testing I had only specified down trains, the exported result was a train ID for the up direction that read the whole row down (the ID was 'TYPE HEADCODE POWER IN WORKING OUT WORKING DAYS') I was amazed that simsig accepted this, but it would be nicer if the exporter gracefully declined the excel file.

lukos commented 2 years ago

Please can you attach a spreadsheet that recreates this.

breadje commented 2 years ago

Vale.of.Glamorgan no up trains.xlsx sure, here you are.

lukos commented 2 years ago

Logic problem in SpreadsheetHelper.cs, Line 208 should be checking for workingColumn == 1 instead of 0. firstCol should also start from 3, not 2 since these are 1-based.