search

lukos / simsig_importer

.Net Desktop Application for converting Excel simplified timetables into Simsig timetables
GNU General Public License v3.0
3 stars 1 forks source link

Departure times ending with 'H' shown as unknown activity codes (LibreOffice issue?) #68

Closed JDeeth closed 1 year ago

JDeeth commented 1 year ago

image I get the above error when importing this timetable created - created with LibreOffice, I don't know if this is a factor: Libreoffice H error demo.xlsx If I remove the H from the times they are imported without error.

lukos commented 1 year ago

Why do we need to accept H in the format?

JDeeth commented 1 year ago

For the half-minute timings e.g.: image

lukos commented 1 year ago

That screenshot is for timetable times, which already support H. The code you changed is related to activities.

lukos commented 1 year ago

I can see now. The code is attempting to get activities and if it doesn't get any AND the entry was not just NNNN then it errors like you showed. You are correct with the need to change this to also accept the H, however you have also added an optional colon between the first and second pair of numbers which I don't think is correct.

JDeeth commented 1 year ago

Sorry, might be misremembering, I thought times could be entered either as 2118 or as (text) 21:18 (and 2118H, 21:18H...)?

lukos commented 1 year ago

Please see the PR comment. Otherwise good to go.