Changes to interceptor engagement

lukrop / GCICAP

Autonomous GCI and CAP script for DCS: World.

Other

7 stars 1 forks source link

Changes to interceptor engagement #22

Closed cjbehm closed 8 years ago

cjbehm commented 8 years ago

I don't know if you're taking PRs but I thought I'd open one with the changes I made. Solves the weird acrobatics I mentioned in the forum thread and avoids the all-knowing engageGroup task type.

Reduces the knowledge of the intercepting group

Only revector if the target has a large detected change in position
Do not use engageGroup task since it knows where the group is
Remove intruders from the list if they are no longer intruding
Allow interceptors to give up

lukrop commented 8 years ago

Of course I do. Thanks! I'll merge this ASAP.

cjbehm commented 8 years ago

I found a bug with GCI spawning while I was working on this, so I fixed that too. I considered doing it in a separate PR, so if you want me to make this PR smaller by doing so I can figure out how to go backwards ;)

lukrop commented 8 years ago

If you would create a separate PR for it I could merge it sooner since the bug you found in your new code isn't fixed yet I assume?

cjbehm commented 8 years ago

Sorry, wasn't clear on what fixes were in the most recent commits I made. 08eac30, 948781b fix the bug I created and commit 237da8b fixes a bug in the original code that wouldn't spawn GCI flights if CAP flights were off.

I think we're clear to merge - I haven't seen any obvious bugs in my test mission.