luksan47 / mars

Eötvös Collegium's Unified IT System
MIT License
4 stars 16 forks source link

Add a user information page #13

Closed luksan47 closed 4 years ago

luksan47 commented 5 years ago

A (currently optional) page where users can fill out personal information (like in Uran 1.1), for later use. Should not be a requirement at registration.

erko185 commented 4 years ago

Hi I can take this problem. Please write me more information where you need this page

luksan47 commented 4 years ago

Hi, thanks! It should be a page under username's dropdown menu. I think the simplest solution is a big form, which should contain the following: Personal information: name, email, address (zip code, city, street, etc could be separated), language, date and place of birth, mother's name, phone number. Information of studies: Name of secondary school Year of the leaving exam Neptun identifier Year of enrollment Faculty, options are:

Workshop, options are (multiple options possible):

luksan47 commented 4 years ago

You can copy most of the page from here (we are rewriting this system): https://github.com/kovacsur10/uran/blob/master/resources/views/user/showdata.blade.php

erko185 commented 4 years ago

Okey I understand. Do you need only page or backend also

erko185 commented 4 years ago

and please add assign in to task

erko185 commented 4 years ago

and insert code to which brands ?

luksan47 commented 4 years ago

Do you need only page or backend also

Once the page is done, updating the backend would be easy, so please add that, too.

and insert code to which brands ?

You can create your own branch or fork the repo, then send a pull request.

erko185 commented 4 years ago

I dont have permission for push into my new branch.Please set me permission. Thanks.

steakhal commented 4 years ago

You won't get permission for this repository. You should fork it, push your local branch into you fork, and create a pull request from that branch to the luksan47/mars/master. @erko185

If you need assistance, feel free to reach out to me.

erko185 commented 4 years ago

Ok. I created pull requst. PLease will you chceck form in info.blade.php. I used form because is more secury than use ajax call. When wil be good page I will create backend. I used basic css. I will use post method for write data into database after.

luksan47 commented 4 years ago

@erko185, you created the Pull Request on your forked repository. Please navigate luksan47/mars (this repository) and open the pull request there, and set the source to your fork. You can check if it's created on this page: https://github.com/luksan47/mars/pulls Also, check this guide out, it describes how to open PRs from forks, just what you need: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

erko185 commented 4 years ago

I did it according to the instructions.

luksan47 commented 4 years ago

Thank you, left some comments there.

erko185 commented 4 years ago

Will I create table for user information and create backend or we give me scheme this table?

luksan47 commented 4 years ago

We can create the backend, after you are done with the UI.

erko185 commented 4 years ago

Form for backend is created but I don't know how to look the form.

steakhal commented 4 years ago

I'm not sure what going on here. Could someone sum it up?

luksan47 commented 4 years ago

@steakhal check out #73