search

luksan47 / mars

Eötvös Collegium's Unified IT System
MIT License
4 stars 16 forks source link

Issue #601: Change the links' color in dark mode #607

Closed viktorcsimma closed 3 years ago

viktorcsimma commented 3 years ago

Tries to fix #601. I had to run npm run prod on Homestead to apply the changes; is it OK?

kdmnk commented 3 years ago

Can you upload a before/after screenshot here? I do not really know what to look for. You changed the links' colour to white? I think we should use something different than the main font colour.

Yes, you need to run the npm run command to generate the css files in the public directory from the resources directory. However, npm run dev is better for developing purposes as it does not compress the files.

viktorcsimma commented 3 years ago

Of course, here you are: Bildschirmfoto von 2021-10-10 22-43-31 The changed one is the "Forgot password" link. Actually, in the preview there aren't as many links like that; they usually come around in real Epistola content.

Also, there is a change on the home page; I think it could be left like that: Bildschirmfoto von 2021-10-10 22-47-23

viktorcsimma commented 3 years ago

One more thing: in normal mode (not dark mode), the preview has red links but the production version has brown ones. I think cyan goes with red, but does it go with the dark blue of Urán?

kdmnk commented 3 years ago

If you set the debug mode to false in the .env file before running npm run dev, you will get the normal colors. You do not need to concentrate on the debug colors, it's just to make the debug site different and to be more mars-like.

I woudnt go with green, try to use some existing colors like the color of the nav bar.

From: viktorcsimma @.> Sent: Sunday, October 10, 2021 10:59:47 PM To: luksan47/mars @.> Cc: Katkó Dominik @.>; Comment @.> Subject: Re: [luksan47/mars] Issue #601: Change the links' color in dark mode (#607)

One more thing: in normal mode (not dark mode), the preview has red links but the production version has brown ones. I think cyan goes with red, but does it go with the dark blue of Urán?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/luksan47/mars/pull/607#issuecomment-939551745, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANMZKMIA2KGRW6ZJ6WBQL7LUGH5EHANCNFSM5EZBTCWA.

viktorcsimma commented 3 years ago

What about the orange secondary colour? Bildschirmfoto von 2021-10-15 12-04-21