[I-04] Inconsistencies in the LSP-7 specification - Githubissues

lukso-network / LIPs

LUKSO Improvement Proposals. Repository for the LUKSO Blockchain Improvement Proposals (LIPs) and LUKSO Standards Process (LSP).

100 stars 44 forks source link

[I-04] Inconsistencies in the LSP-7 specification #274

Closed YamenMerhi closed 10 months ago

YamenMerhi commented 10 months ago

What does this PR introduce ?

Add missing parameters and requirements as follow:

authorizedAmountFor

Parameters
- Add tokenOwner missing parameter

increaseAllowance

Requirements
- operator cannot be calling address.
- operator cannot be the zero address.

decreaseAllowance

Requirements
- operator cannot be calling address.
- operator cannot be the zero address.
- subtractedAmount must be less than the operator's current allowance.

transferBatch

Requirements
- from, to, amount, force, and data lists are the same length.

Interface Cheat Sheet

transferBatch() - force parameter bool array --> bool[] memory force.
batchCalls() - data parameter calldata. --> memory.

To be discussed:

transfer

Requirements
- from and to cannot be the same address.

transferBatch

Requirements
- from and to cannot be the same address.