search

lukso-network / tools-lukso-cli

This repository serves as a CLI to download and/or run lukso dependencies
https://docs.lukso.tech/networks/mainnet/running-a-node/#lukso-cli-node-setup
Apache License 2.0
12 stars 6 forks source link

feat: Add validator list command #126

Closed fhildeb closed 1 year ago

fhildeb commented 1 year ago

This PR introduces the feature to automatically list all imported validator keys for a specific network's keystore folder.

It triggers the validator accounts list command from the Prysm Validator and lets the user interact with it directly to input the password, so security is not on our end.

Usage

lukso validator list --devnet (or --mainnet, or --devnet) lukso validator list (default is set to mainnet, not enabled yet)

Showcase and Process Info

As the picture shows, we cannot modify outputs as the command executes the Prysm Validator itself. Therefore, it still shows the terms eth1 and Ethereum Mainnet. This is similar to all other clients printing output or warnings without the LUKSO CLI's awareness.

I tried to use a subcommand terminal (like github.com/kr/pty) to buffer the output. However, this will limit us regarding OS support, increase the complexity of the CLI tool, and will introduce additional maintenance if outputs change in future client versions. It's best to leave client outputs as they are.

Bildschirmfoto 2023-05-04 um 12 52 59
github-actions[bot] commented 1 year ago

:rocket: Deployed preview to curl https://install.lukso.network/126 | sh