fix: Some more upgrades. Local environment has yarn links in it.

lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.

https://up-test-dapp.lukso.tech/

17 stars 14 forks source link

fix: Some more upgrades. Local environment has yarn links in it. #104

Closed richtera closed 1 year ago

richtera commented 1 year ago

fix: More upgrades to point to npms.

During local testing yarn links existed to pull in the lastest lsp-smart-contracts and lsp-factory so during deployment (i.e. up-test-dapp) LSP7/8 create contract didn't work.

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`5bac763`
Status:	✅ Deploy successful!
Preview URL:	https://3b21e663.universalprofile-test-dapp.pages.dev
Branch Preview URL:	https://fix-more-required-upgrades.universalprofile-test-dapp.pages.dev

View logs

github-actions[bot] commented 1 year ago

PR Preview Action v1.2.0 :---: Preview removed because the pull request was closed. 2023-04-27 08:57 UTC

richtera commented 1 year ago

I tried the LSP7/8 deployment this morning and it all of a sudden didn't work again. As far as I can tell this must have been related to most of my testing being done in a repo with yarn links to the latest lsp-factory and lsp-smart-contracts since this showed the old estimateGas error. Trying to redeploy just to see, will look at it on Tuesday.

frozeman commented 1 year ago

Task linked: CU-862jkhyqk UPTest: More upgrades necessary in test-dapp.

jnorbert commented 1 year ago

@Hugoo could you check please the above PR and merge it?