fix: Remove github actions since we're doing all this in cloudflare.

lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.

https://up-test-dapp.lukso.tech/

17 stars 14 forks source link

fix: Remove github actions since we're doing all this in cloudflare. #108

Closed richtera closed 1 year ago

richtera commented 1 year ago

Since we're executing all the deploy stuff in cloudflare there is really no need to re-do things in github actions. Gut feeling is delete it and we're good.

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`ba13e68`
Status:	✅ Deploy successful!
Preview URL:	https://459f6cf5.universalprofile-test-dapp.pages.dev
Branch Preview URL:	https://fix-remove-gh-pages.universalprofile-test-dapp.pages.dev

View logs

richtera commented 1 year ago

@Hugoo We will need to disable the required lint-build-test thing since all that is happening on cloudflare.

Hugoo commented 1 year ago

@richtera The good part of having the lint in GitHub is that everyone can see the output, and if something goes wrong, we can also see it. Not everyone has access to Cloudflare to see the logs. I think GitHub PR page is a better place to see that info.

The lint step is quite fast anyway? I think we lose more than we win.

We lose:

info about the CI output

We win:

slightly faster CI
less duplicated actions

richtera commented 1 year ago

Oh sure. We need to lint inside of cloudflare but it won't hurt to do it twice. Changing that back

richtera commented 1 year ago

Closing this one.