lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.
https://up-test-dapp.lukso.tech/
17 stars 14 forks source link

chore: reverted back walletconnect v2 update; rebased #111

Closed richtera closed 1 year ago

richtera commented 1 year ago

Create a rebased branch with fixed jest tests.

richtera commented 1 year ago

@JeneaVranceanu I am seeing a build failure in cloudflare with an error 129 BTW: This is the current build command

yarn lint:js && yarn lint:css && yarn lint:format && yarn lint:types && yarn test:unit && yarn build
JeneaVranceanu commented 1 year ago

@JeneaVranceanu I am seeing a build failure in cloudflare with an error 129 BTW: This is the current build command

yarn lint:js && yarn lint:css && yarn lint:format && yarn lint:types && yarn test:unit && yarn build

Could be related to updated dependencies. Will run it locally to see the details.

JeneaVranceanu commented 1 year ago

1 test failed. Definitely a dependencies issue.

Screenshot 2023-06-12 at 12 31 50

Update: the used address wasn't checksummed 0x117216362d594516C6f96ee34B2C502D65b847E4.

But now the test fails with a different issue:

Screenshot 2023-06-12 at 12 36 41

richtera commented 1 year ago

@JeneaVranceanu I am seeing a build failure in cloudflare with an error 129 BTW: This is the current build command

yarn lint:js && yarn lint:css && yarn lint:format && yarn lint:types && yarn test:unit && yarn build

Could be related to updated dependencies. Will run it locally to see the details.

Possibly, but it does run locally. Usually 129 means that the build either took too long or ran out of memory. To fix that we can definitely switch back to github actions and then user a wrangler cloudflare pages deploy. It's a little bit more complicated but has the added advantage that you can read the log as a non-cloudflare developer/admin.

richtera commented 1 year ago

Switching to cloudflare deployment by using github actions.

github-actions[bot] commented 1 year ago

Deployed with Cloudflare Pages :cloud: :rocket: :ok:

richtera commented 1 year ago

@JeneaVranceanu I repaired the URL mismatch and patched a problem with the profiles pages.

JeneaVranceanu commented 1 year ago

@JeneaVranceanu I repaired the URL mismatch and patched a problem with the profiles pages.

Oh, nice! Will start the review now.

richtera commented 1 year ago

I changed the base ok this PR so the other one is no longer separate. At this point it would only cause additional work