lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.
https://up-test-dapp.lukso.tech/
17 stars 14 forks source link

fix: removes desktop check #118

Closed andyogaga closed 1 year ago

andyogaga commented 1 year ago

UPD: wallet connect must work from any platform. But in it's current state it interferes with connection that's made between DApp and extension.

From Connect.vue:

onMounted(async () => {
  await setupWCV2Provider()
  const wcv2Provider = getWCV2Provider()
  if (wcv2Provider && wcv2Provider.connected) {
    // All set up already
  } else if (browserExtensionConnected) {
    await connectExtension()
  }
  addEventListeners()
})

As we can see setupWCV2Provider is executed from the very beginning which breaks the connection between DApp and extension.

UPD 2: here is a recording of this fix in action.

https://github.com/lukso-network/universalprofile-test-dapp/assets/36865532/ae1247c9-adc5-47a3-ad66-4254fd7ec44c

frozeman commented 1 year ago

Task linked: DEV-5974 BUG: Update Test dApp to easily work with testnet

github-actions[bot] commented 1 year ago

Deployed with Cloudflare Pages :cloud: :rocket: :ok: