search

lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.
https://up-test-dapp.lukso.tech/
17 stars 14 forks source link

fix: use setData instead of setDataBatch #134

Closed andyogaga closed 1 year ago

andyogaga commented 1 year ago

https://app.clickup.com/t/2645698/DEV-8266

frozeman commented 1 year ago

Task linked: DEV-8266 Bug: setData in test dApp is displayed as setDataBatch in the Extension

richtera commented 1 year ago

@andyogaga This is not required. The reason it didn't work was when we changed the component name to display SetDataBatch, there was something in the background determining if something was a setData by looking at the component name. Unfortunately the isSetData condition didn't include the new name. @Esanim and I changed it to include the name of both and fixed a second isSetDataTransaction to also look at both signatures. We decided to use the two signature condition. https://github.com/lukso-network/universalprofile-extension/pull/984

andyogaga commented 1 year ago

not required