lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.
https://up-test-dapp.lukso.tech/
17 stars 14 forks source link

fix: ABI decoding should take place instead of random cache being returned #163

Closed JeneaVranceanu closed 6 days ago

JeneaVranceanu commented 6 days ago

The issue: pasting ABI of encoded function may read and show invalid arguments in the UI. The reason: last saved value stored in signature-cache2, which includes all decoded values of the last input, is returned if it matches the function selector of the given ABI.

Instead we should only take function signature from the cache if anything is found and then decode given ABI encoded function call.

Bug:

https://github.com/user-attachments/assets/f8a40b18-ad2e-45a7-bd12-80c8f6b4ecc8

Bug solved:

https://github.com/user-attachments/assets/a9760ecb-9dbb-427f-b969-76817dcda479

github-actions[bot] commented 6 days ago

Deployed with Cloudflare Pages :cloud: :rocket: :ok: