fix: Upgrade to yarn, upgrade npms, move panels

lukso-network / universalprofile-test-dapp

Testing dApps for ERC725 and Universal Profiles.

https://up-test-dapp.lukso.tech/

17 stars 14 forks source link

fix: Upgrade to yarn, upgrade npms, move panels #91

Closed richtera closed 1 year ago

richtera commented 1 year ago

Fix: Upgrades and start working on improvements

https://app.clickup.com/t/3d36qrp

change to yarn
upgrade required npms
repair code affected by dependencies
add web3-eth-contract as a dependency to force web3 internal dep.
move panes around
add custom dropdown for accounts and LSPs

Added a test deploy at https://whispering-pear.surge.sh

frozeman commented 1 year ago

Task linked: CU-3d36qrp Improvements for up-test dApp

richtera commented 1 year ago

@samuel-videau @dzbo Converting to draft. Refactoring transaction dropdown to actual function prototypes and setup each parameter as a field instead of having "pre-populated" combinations of parameters.

github-actions[bot] commented 1 year ago

PR Preview Action v1.2.0 :---: Preview removed because the pull request was closed. 2023-01-04 14:12 UTC

Hugoo commented 1 year ago

Very cool!

I'm not sure if this:

Is relevant - or at least in that area of the app. But I guess it is fine for now and not such of a big deal.

richtera commented 1 year ago

wow lot of improvements thanks!

Is it possible to make smaller PR next time tho 😁

I found that this select field does not work anymore?

I didn't understand all the things related to encoding, decoding a tx in the ContractFunction file - let's make sure this app stays simple.

If you don't have that kind of token then you need to manually type it in. Previously it would pre-populate the token, but it belonged to Dominik. Do we want to add sample ERC721 things into the menu? Currently "address" values always show the dropdown and the text box, but if the specific address type doesn't have any items in it then the dropdown will be empty for that type.