search

lula / ngx-soap

Simple SOAP client for Angular
MIT License
66 stars 61 forks source link

Angular 7 support #33

Closed szymonworld closed 4 months ago

szymonworld commented 5 years ago

Hi, Any plans to support angular 7 ? When I'm trying to use ngx-soap 0.5.0-beta.7 with angular 7 I'm getting warns during npm install: npm WARN ngx-soap@0.5.0-beta.7 requires a peer of @angular/common@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-soap@0.5.0-beta.7 requires a peer of @angular/core@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-soap@0.5.0-beta.7 requires a peer of buffer@^5.1.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-soap@0.5.0-beta.7 requires a peer of crypto-js@^3.1.9-1 but none is installed. You must install peer dependencies yourself. npm WARN ngx-soap@0.5.0-beta.7 requires a peer of events@^3.0.0 but none is installed. You must install peer dependencies yourself. npm WARN ngx-soap@0.5.0-beta.7 requires a peer of sax@^1.2.4 but none is installed. You must install peer dependencies yourself.

And during ng serve node_modules/ngx-soap/ngx-soap"' has no exported member 'Operation'. node_modules/ngx-soap/ngx-soap"' has no exported member 'SOAPService'

lula commented 5 years ago

Hello @szymonworld as far as I can see Angular 7 is already supported as there are no breaking changes impacting this lib. Anyway, I just tested with Angular 7.1.1 and everything works as expected. Anyway, well, I have to agree npm warnings can be scary and certainly there will be official support for Angular 7.

I'll leave this issue open as a reminder to upgrade to Angular 7. In the meantime, please try yourself and let me know if you encounter any problem.

robli314 commented 5 years ago

I am using it with Angular 7, and it works fine for me.

xel-x commented 5 years ago

Works for me with angular 8