lula / ngx-soap

Simple SOAP client for Angular
MIT License
66 stars 61 forks source link

Tags XML after transformation contain multiple xmlns attributes #47

Open robli314 opened 5 years ago

robli314 commented 5 years ago

Hi, I realized that the following code in wsdl.ts on line 1922: ... xmlnsAttrib += childXmlnsAttrib; ...

generates the following output: ... <ns0:joinedAssignments xmlns:ns0="http://draft.schedule.domain.api.m" xmlns:ns0="http://draft.schedule.domain.api.m" xmlns:ns0="http://draft.schedule.domain.api.m" xmlns:ns0="http://draft.schedule.domain.api.m">false </ns0:joinedAssignments> <ns0:iitLinkedAssignments xmlns:ns0="http://draft.schedule.domain.api.m" xmlns:ns0="http://draft.schedule.domain.api.m" xmlns:ns0="http://draft.schedule.domain.api.m" xmlns:ns0="http://draft.schedule.domain.api.m">false </ns0:iitLinkedAssignments>...

Maybe that code could be replaced by: ... xmlnsAttrib = childXmlnsAttrib; ...

To be honest it is kind of redundant to have the xmlns on the attribute, as you are already declaring it on the envelope header.