search

lula / ngx-summernote

Summernote editor for Angular :sunglasses:
MIT License
102 stars 42 forks source link

Upgrade to angular 14 (Ivy compatibility) #182

Closed floAtEbcont closed 1 year ago

floAtEbcont commented 1 year ago

Fixes #145

dancornilov commented 1 year ago

@llulani Hey, it's possible to merge this think? Because now this package is not compatible with Ivy, and we cannot update the version of whole project.

Thanks in advance

ManuBucaciuc commented 1 year ago

Do we have any updates regarding this issue? Making this library Ivy compatible would be awesome in order to update my project to latest Angular version 🙏 .

Thank you for your work!

lula commented 1 year ago

Hi everyone! I'm quite busy with work and unfortunately I only have a little time spare 😞 . Anyways, this PR has been merged into version 1.0.0! Many thanks to @floAtEbcont who did the actual job 💪 🙏

floAtEbcont commented 1 year ago

Hi everyone! I'm quite busy with work and unfortunately I only have a little time spare disappointed . Anyways, this PR has been merged into version 1.0.0! Many thanks to @floAtEbcont who did the actual job muscle pray

@lula Thanks for merging & publishing! :grin: The new version seems to work fine with our angular 16 app. Should any upgrade related issues arise, you may try to contact me - it would be in my own interest to fix them :wink:

lula commented 1 year ago

@floAtEbcont thank you for your help 🙏 ! It would be wonderful if you'd like to join as a contributor of this repo. Would you consider it?

floAtEbcont commented 1 year ago

@lula Oh... No, I'm afraid I've got too much on my hands already to be added as a contributor. But thank you for your trust :)

lula commented 1 year ago

@floAtEbcont I understand. Thank you anyway! 😄