search

lulu-berlin / rusty-typescript

A TypeScript compiler written in Rust
https://twitter.com/TypescriptRusty
Apache License 2.0
235 stars 6 forks source link

Use wasm-pack-npm to install rust and wasm-pack #27

Closed lulu-berlin closed 5 years ago

lulu-berlin commented 5 years ago

This uses wasm-pack-npm to install rust and wasm-pack. This way the CI build can be simplified.

lulu-berlin commented 5 years ago

For some reason, the build hangs when wasm-pack-npm tries to install cargo-generate.

robertohuertasm commented 5 years ago

@yever, I'm removing cargo-generate from the installation. I think it's maybe overkilling. It takes a lot of time and not everybody needs it. I'm preparing a new version.

lulu-berlin commented 5 years ago

@robertohuertasm Thanks!

robertohuertasm commented 5 years ago

New version ready! Let me know if it works for you.

lulu-berlin commented 5 years ago

Yes, I saw. I'm testing it now.

lulu-berlin commented 5 years ago

Seems like if rust and wasm-pack already exist, it skips setting the default toolchain which makes wasm-pack fail.

lulu-berlin commented 5 years ago

@robertohuertasm Why did you remove setting the default toolchain to nightly as part of the same commit where your removed installing cargo-generate? https://github.com/robertohuertasm/wasm-pack-npm/commit/3845e4e3fe552df271231f795ffe71d45675faab ("no nightly, no cargo-generate")