Add 1 day of cache to CDN route - Githubissues

luludotdev / beatsaver-reloaded

BeatSaver Again

ISC License

181 stars 50 forks source link

Add 1 day of cache to CDN route #124

Closed byhemechi closed 3 years ago

byhemechi commented 3 years ago

Proposed Changes

I've add a max-age directive to the cdn route, this will cause cloudflare to cache zip downloads for a day, significantly reducing origin load

Platforms

This pull request modifies: (select all that apply)

[ ] Client
[x] Server

Types of Changes

This pull request is contains: (select all that apply)

[x] Bug fixes (non-breaking change which fixes an issue)
[ ] New features (non-breaking change which adds functionality)
[ ] Breaking changes (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the contribution guidelines
[x] I have checked the changes adhere to the project's style guide and all tests pass
[x] I have (to the best of my ability) checked for vulnerabilities, or any ways that my code could be abused and concluded that it is safe to run in production

Further Comments

I've set the maxage to 24 hours, which is pretty short. This can definitely be increased.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.