Hiding auto generated maps can lead to loading very few new maps

[tomjschwanke]

Platform

This bug report concerns: (select all that apply)

• [x] Client
• [ ] Server This is much more client-side, since the server doesn't know whether you're filtering auto generated maps or not.

Details

Please describe the problem you are having in as much detail as possible: When I go to "hot" and scroll down I have to hit "Load more" to continue scrolling, however if there are a lot of auto generated maps in there and I have chosen to hide them, there can be cases where only 1-2 or even no new maps are shown. This can get frustrating if you have to click "Load more" 5 times in a row just to see 3 new maps.

Reproducing the Problem

Please include detailed steps to reproduce the problem: Scroll through "hot" until you notice the problem

Possible fix

Either let the server do the filtering (signal to not send auto generated maps) or load more maps if there are autogenerated ones in there.

[tomjschwanke]

Digging through the code and playing around with requests, I have an idea of what's going on.

Requesting https://beatsaver.com/api/maps/hot/0 will return results without automapped maps Requesting https://beatsaver.com/api/maps/hot/0?automapper=1 instead will return results including auto generated maps (Requesting with automapper=0 leads to a Bad Request response)

It seems that the client is always requesting with automapper=1, so it should just leave that out when requesting new maps and the checkbox "Show auto-generated Beatmaps" isn't ticked.

As I don't have any experience with TypeScript, I'm not sure if I could fix it, but that should be everything you need to know for a fix.

[luludotdev]

This will be addressed with the client rewrite, which will happen soon:tm: