Open ethanshoemaker opened 2 years ago
"NotImplementedError: Polygon.periodic_point to be implemented"
Hi Lu Lu, Thanks for the response. Does this mean periodicBC cannot be implemented for polygon geometry?
In general, yes, for example, how to define a periodic BC for a triangle?
But for special cases, it can be defined. But you need to implement case by case.
Hi Lu Lu, Thank you for the response, I have begun to implement this by modifying the source code on my machine. I have a couple of questions regarding this. If, for example, I have a square geometry and I want periodic BC for y-direction (i.e. periodic for top and bottom), would I need my function periodic_point to include points on both of these boundaries or just one? Additionally, I have the same question for the argument 'on_boundary' into PeriodicBC. Should this include both boundaries or just 1? Thanks, Ethan
Also, my losses from PeriodicBC are exactly 0. I am having a hard time understanding if this is correct or not?
would I need my function periodic_point to include points on both of these boundaries or just one?
Yes.
I have the same question for the argument 'on_boundary' into PeriodicBC. Should this include both boundaries or just 1?
Both boundaries.
my losses from PeriodicBC are exactly 0. I am having a hard time understanding if this is correct or not?
Then it might be not correct.
I am having difficulty interpreting this error. Is anyone able to help me on this? I assume it should be an easy fix.