search

lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
150 stars 17 forks source link

Added League Of Legends stats to Session card #121

Closed Segergren closed 1 year ago

Segergren commented 1 year ago

Part of #108. Requested by @byotta image

lulzsun commented 1 year ago

Looks good, but I feel like we should include the champion icon and the victory/loss label before I merge this.

Are we able to pass that information to video metadata as well?

Segergren commented 1 year ago

Looks good, but I feel like we should include the champion icon and the victory/loss label before I merge this.

Are we able to pass that information to video metadata as well?

The champion icon is possible for sure 👍 I’ll check if victory/loss is possible :)

Segergren commented 1 year ago

Added the champion and win/loss indicator image

lulzsun commented 1 year ago

Thanks! I went ahead and adjusted the design a little bit, here is how it looks now: image

I think it is ready for merge now, thanks again for your time and work!