search

lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
128 stars 16 forks source link

Recording wrong application #122

Closed Asgaroth closed 10 months ago

Asgaroth commented 1 year ago

I am trying to record League of Legends and I have Chrome with a video playing. When the game starts RePlays correctly starts recording, after finishing tho, the recording is of the video in chrome and not the game

image

image

lulzsun commented 1 year ago

Are you on stable release? Nightly had some changes made with regards to the recording backend that may solve this issue.

The reason why this happens is because the game capture mode failed. When that happens we default to display capture mode, which is probably why you see recording of chrome and your taskbar.

Is this recording from a second monitor? If so, is this display defined as your primary monitor?

Asgaroth commented 1 year ago

Thanks for the quick reply.

Yes, I just installed the app yesterday from the last stable release. I only have one monitor. My league client seems bugged in that I have it on windowed borderless but it keeps resetting to fullscreen, not sure if that is causing the game capture mode to break. Will test nightly later today.

Asgaroth commented 1 year ago

It seems to be working now. No wrong recordings last night. Thank you!

And thank you for reviving this!

Asgaroth commented 1 year ago

I see a new behavior, it will now record both the browser and the game, but it will only record the game for 30 seconds before stoping. The first few minutes are the browser.

image

lulzsun commented 1 year ago

Interesting behavior, does it appear to happen often? I am currently investigating such recording issues and would like any details if you can find any correlation to this occurrence. It does not appear to occur on my machine so I am unable to understand the reason behind this issue.

Also feel free to provide the logs here and whenever it occurs again (some logs get purged in-case the file size gets too big), they might help in solving the issue. They can be retrieved through Settings > Help.

Asgaroth commented 1 year ago

Thank you for looking into it. Originally I had a hint it had to do with automanaged disk space. But it did record some games, i'd say about 3/4 games would be 1-2 min recordings, and then one full recording. I changed my settings to keep them by days instead of by disk space and will report back when I have tested tonight.

logs.txt

Edit: After changing to days instead of disk space, its still happening.

image

logs.txt

lulzsun commented 1 year ago

I've pushed some potential fixes towards this issue, but I am unsure if it will actually solve this particular situation. This issue has been troublesome lately because I have been unable to replicate this and other issues related to recording stopping early #124 (the dreaded, "but it works on my machine!...").

Let me know if you get better results with the new changes.

lulzsun commented 10 months ago

The refactoring of the recording backend has been deemed complete. A lot of related issues have been reported to be resolved but this one has gone stale for some time.

I will be closing this assuming that the issue has been resolved, but please feel free to report back if you say otherwise and I can reopen this issue. Thanks!