search

lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
162 stars 18 forks source link

set max_bitrate to match bitrate when using vbr #132

Closed eiqnepm closed 1 year ago

eiqnepm commented 1 year ago

I have noticed that VBR is recording at a much lower bitrate than I expect.

When set to 15 Mb/s I see my recordings peaking at 5 Mb/s. I do not have this issue with OBS, I believe this might be because I have max bitrate to match bitrate, I figure that max bitrate being unset may be throttling the bitrate in RePlays.

I am unable to test this commit at the moment. I am not familiar with C# or the OBS libraries, however the change I made was very trivial.

If someone could build this for me to test, that would be fab!

Segergren commented 1 year ago

I'll try it out :) Do you know how I can see the bitrate of the video?

eiqnepm commented 1 year ago

I'll try it out :) Do you know how I can see the bitrate of the video?

If you're on Windows you can right click the file, select properties, select details, and you should be able to see total bitrate under video.

Segergren commented 1 year ago

I'll try it out :) Do you know how I can see the bitrate of the video?

If you're on Windows you can right click the file, select properties, select details, and you should be able to see total bitrate under video.

So what do you see in your video, a maximum of 5000kbps?

eiqnepm commented 1 year ago

I'll try it out :) Do you know how I can see the bitrate of the video?

If you're on Windows you can right click the file, select properties, select details, and you should be able to see total bitrate under video.

So what do you see in your video, a maximum of 5000kbps?

Roughly yes.

I can tell that it is not just the average and is indeed the peak because I can use VLC, tool, media information, statistics, input bitrate to see the bitrate as the recording is playing in high movement areas.

Segergren commented 1 year ago

Your fix works well! It got up to 46750kbps (and a HUGE file 😁)

eiqnepm commented 1 year ago

Your fix works well! It got up to 46750kbps (and a HUGE file 😁)

What was it for you before the change?

lulzsun commented 1 year ago

I noticed this when VBR was first implemented, but I forgot about it because I was using CBR. I have briefly tested it but cannot properly confirm working since my recordings were not getting close to max bitrate (set 50MB but only seeing ~1MB), although it was lower without setting max bitrate.

However, I was only testing for a couple of seconds of recording so maybe that's why it didn't reach close to max bitrate. I will assume that it working as intended, given @Segergren's feedback.

Maybe in the future we can have an option to set both min/max bitrate for better control and functionality.

Thanks again for looking into this. Ready to merge.