Support for other file formats including fragmented video files. #103

lulzsun / RePlays

Open-source game recording management software

GNU General Public License v3.0

128 stars 16 forks source link

Support for other file formats including fragmented video files. #103 #140

Closed CallumCarmicheal closed 11 months ago

CallumCarmicheal commented 11 months ago

Add support for additional file formats (#103 - Support .mkv video format)

[x] Change compressor to support .mkv files
[ ] Change uploaders to support .mkv files
[x] Create a user setting to change output file format (.mp4, .mkv)
[x] Add information panel advising users to change to a fragmented / recoverable format like MKV or Fragmented MP4.

Uploaders have not been touched, only the local file list and a selection box for what is the prefered file format.

File formats accepted added from OBS:

MP4 (MPEG-4 .mp4)
MKV (Matroska Video .mkv)
Fragmented MP4 (MPEG-4 .mp4)
Fragmented MOV (.mov)
FLV (Flash Video)
Quicktime (.mov)
MpegTS (.ts) // This is not tested

CallumCarmicheal commented 11 months ago

The Information / warning popup for the file format looks like this. Its only visible when not selecting MKV, Fragmented MP4/MOV. I had also moved the Encoder and Rate control to a new line.

A good idea might be aligning the flex into columns although I never got around to fully learning flex boxes this would have to be done by someone else.

Segergren commented 11 months ago

Nice! Personally I think the alert is a bit too much since the possibility that RePlays crashes is relatively low.

CallumCarmicheal commented 11 months ago

I'll swap it out for a simple text label saying something like "It is recommended to use a fragmented video format to decrease risk of corrupted videos in case of computer crash" top of my head

Got a better comment or just remove the info label all together? @Segergren

Segergren commented 11 months ago

Got a better comment or just remove the info label all together? @Segergren

I think removing it all together, what do you think @lulzsun?

CallumCarmicheal commented 11 months ago

Thanks for cleaning it up, will you have a chance to get around to creating a linting syntax guide? With my current setup its hard to read code that is 2 line intended. So I tend to format the code, write the changes then reformat it. I had forgotten that there is no linting setup so this step was missed, sorry about that.

lulzsun commented 11 months ago

I thought of just having everything 4 space or tabbed, since the C# portion is already setup that way. The React portion was lazily put together and I wasn't really expecting to have many contributors at the time, so I didn't bother to set it up for it. So no worries! I will be looking into it.

lulzsun commented 11 months ago

Got a better comment or just remove the info label all together? @Segergren

I think removing it all together, what do you think @lulzsun?

I think the info label is a good idea, maybe a little too big but it can be adjusted. In the future, we may just have the default setting as .mkv for session recording. So the info label would only be visible to users who care to switch to .mp4, which I think is fine.