lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
128 stars 16 forks source link

Support for CS2 recording #144

Closed ArnoldBraine closed 7 months ago

ArnoldBraine commented 9 months ago

Currently CS2 games are not being recorded, is there already a known workaround? hopefully this would be an easy fix!

Segergren commented 9 months ago

This is a known issue and CS2 has blocked us and OBS from using Game Capture. There is currently no known way to capture it without using Display Capture (which is pretty bad)

m8nu commented 9 months ago

Does it work with -allow_third_party_software ?

ArnoldBraine commented 9 months ago

@m8nu This won't start CS2 in trusted mode which means you won't be able to play on VAC secured servers (AKA the whole game)

m8nu commented 9 months ago

In GO you can play but with low trust factor

ArnoldBraine commented 9 months ago

Won't be recording much highlights getting headshotted by cheaters spinning around 😆

Segergren commented 9 months ago

I tried it and completely destroyed my Trust Factor for months :(

ArnoldBraine commented 9 months ago

Yeah i wouldn't recommend doing so, maybe there could be like a "experimental features" checkbox where you would enable screencapture instead of gamecapture for CS2? Would it just be bad quality or really hit the hardware? because if you have the hardware to throw at it, it think that would be a nice temporary "solution"

jkluch commented 8 months ago

Yeah i wouldn't recommend doing so, maybe there could be like a "experimental features" checkbox where you would enable screencapture instead of gamecapture for CS2? Would it just be bad quality or really hit the hardware? because if you have the hardware to throw at it, it think that would be a nice temporary "solution"

In my experience I've noticed negligible performance difference in obs using display capture vs game capture. Sure, technically there are performance gains going the game capture route.. but realistically I don't think they matter that much. Maybe on a very low end machine. The only actual issue with display capture is games running in fullscreen exclusive mode don't get captured properly.

I'm not really a fan of display/game capture being a global option either though. IMO it should default to game capture with the ability to override to display capture per game. Ideally RePlays would ship with some prebaked overrides included for games known to conflict with game capture like Counter Strike and Rainbow 6 Siege.

Segergren commented 8 months ago

148 Has added support for CS2 recording

150 Has added CS2 integrations (automatic kill bookmarks)

Segergren commented 8 months ago

Should be fixed now in latest 1.2.45. Can you verify @ArnoldBraine?

ArnoldBraine commented 8 months ago

Hi there :)

Can confirm it works for me and another friend! Great work, one small detail. Not sure how easy it is to detect whether someone is playing another resolution, but i play 4:3 so my game looks like this Would it be alot to check the resolution and stretch it afterwards to native? If it is too much work, don't bother 😄

KR, Arnold

RavenStryker commented 8 months ago

Would it be alot to check the resolution and stretch it afterwards to native? If it is too much work, don't bother 😄

Why would you want to stretch a 4:3 replay/clip into something different? They can't magically add game footage where it doesn't exist so everything would look oddly out of proportion and skewed really wide if that took place. Unless I'm misunderstanding what you mean by the quoted piece above.

ArnoldBraine commented 8 months ago

@RavenStryker, Okay so basically:

Segergren commented 8 months ago

@ArnoldBraine Can you send me a log file of when you start and end a CS2 recording?

ArnoldBraine commented 8 months ago

@Segergren, which type of log file am i looking for? + noticed one more thing, the automatic kill bookmarks, does that already work? (https://github.com/lulzsun/RePlays/pull/150 Has added CS2 integrations (automatic kill bookmarks))

lulzsun commented 8 months ago

@ArnoldBraine If you navigate to Settings > Help, you should be able to locate the logs file for us.

And yes, it should be possible to stretch-to-fit the video as a setting option.

ArnoldBraine commented 8 months ago

I extracted from start to finish of a session extract_log.txt

Segergren commented 8 months ago

Can you create a new feature request so we close this issue @ArnoldBraine?

Segergren commented 7 months ago

@lulzsun Can you close this issue?

lulzsun commented 7 months ago

Closing this issue.