search

lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
162 stars 18 forks source link

feature: Add Replay Buffers #200

Closed sshcrack closed 5 months ago

sshcrack commented 7 months ago

This pull request adds the replay buffer feature requested in #47. The PR libobs_sharp/#1 has to be merged first so the method obs_output_get_id can be used.

sshcrack commented 7 months ago

oh, also I accidentally left a whitespace in the libobs-sharp.example project. This pull request fixes the issue.

sshcrack commented 5 months ago

Hey, it's been a while. Are we ready to merge?

Segergren commented 5 months ago

Should we create a new stable version and then merge this @lulzsun?

lulzsun commented 5 months ago

Hi, sorry I was busy. I planned to test this last week but ended up forgetting, so I just took some time right now to try it out.

It looks like it works well, so I'll be merging this right away. I think I want to create a stable version with this feature in as it is one of the most requested feature, but let's have other users test it out in nightly before we do so.

Thanks again for the pull request!

sshcrack commented 4 months ago

Were there any issues? If not are we ready for a stable release?

Segergren commented 4 months ago

@sshcrack I suggest disabling fragmented output options as they are not compatible, see #207 👍

sshcrack commented 4 months ago

Oh, didn't see that issue, will draft a PR later