lulzsun / RePlays

Open-source game recording management software
GNU General Public License v3.0
150 stars 17 forks source link

Issue with saving encrypted password to userSettings.json #97

Closed lulzsun closed 1 year ago

lulzsun commented 1 year ago

There is an issue where if userSettings are repeatedly changed, saved passwords for upload services are being lengthened(?) to the point where the userSettings.json file size increases drastically.

From my debugging, it ended up increasing to 100MB~ (default settings is around 4KB).

This probably explains why sometimes there is sometimes an upload authentication error, because the encrypted password becomes incorrect when this occurs.

This also causes extreme interface lag if the settings json is large, because it is being reloaded every time a setting is changed.

lulzsun commented 1 year ago

The fix should be ready in the next nightly and next stable (v1.2.1+).