search

lume / glas

WebGL in WebAssembly with AssemblyScript
https://lume.io
MIT License
887 stars 45 forks source link

convert Math.sin/Math.cos into Math.sincos calls for 1.5 to 1.8x perf improvement #112

Closed StEvUgnIn closed 3 years ago

StEvUgnIn commented 3 years ago

this commit follows issue #45

invoke these errors: https://gist.github.com/StEvUgnIn/2ba404abe92cab0ac432cc7ed7ac7fe1

p3nGu1nZz commented 3 years ago

@StEvUgnIn for whatever reason github wont automerge. could you please try rebases your fork branch and updating. Sorry for the inconvenience.

trusktr commented 3 years ago

@ZoeDreams Not mergeable because the branch is out of date. @StEvUgnIn you can update the branch (there's an Update button near the bottom of this page), then tests will run again, then it will be mergeable if tests pass.

Set up to be scrupulous.

trusktr commented 3 years ago

I went ahead and merged it for this time, but keep in mind the branches become mergeable if they are both up-to-date and tests passing.

trusktr commented 3 years ago

Thanks @StEvUgnIn !

StEvUgnIn commented 3 years ago

I updated it last time... this is marked by rebase...

trusktr commented 3 years ago

Each time any other PR is merged, then all remaining PRs are considered out of date. So probably one was merged after you updated last time.