search

lumeland / imagemagick-deno

Deno port of the WASM library for ImageMagick
https://deno.land/x/imagemagick_deno
Apache License 2.0
44 stars 3 forks source link

Overload needed when using read with `color, width, height, (for settings)` #4

Closed reggi closed 1 year ago

reggi commented 1 year ago

I suggest adding an optional forth argument when these are in use for MagickReadSettings.

color, width, MagickReadSettings, callback color, width, height, MagickReadSettings, callback

When width is provided without height just set height to the width for square 🤷

oscarotero commented 1 year ago

Hi. Thanks but this repo only contains the same code as https://github.com/dlemstra/magick-wasm but with some modifications to make it work on Deno. So you should open the issue in the original repository.

reggi commented 1 year ago

@oscarotero yeah I had a feeling that was the case, sorry for opening all these up, feel free to close them.