lumeland / lume.land

The website of lume.land
https://lume.land
MIT License
68 stars 65 forks source link

Add `--allow-read` argument to CLI install instructions #109

Closed mash-graz closed 5 months ago

mash-graz commented 5 months ago

Deno.execPath() as used in the more recent lume-cli scripts needs read access. Otherwise, you get a nasty warning on every invocation:

lume -h
┌ ⚠️  Deno requests read access to <exec_path>.
├ Requested by `Deno.execPath()` API.
├ Run again with --allow-read to bypass this prompt.
└ Allow? [y/n/A] (y = yes, allow; n = no, deny; A = allow all read permissions)
netlify[bot] commented 5 months ago

Deploy Preview for lumeland ready!

Name Link
Latest commit 530203199a7402b9dbe1e9acf2976b8de5820702
Latest deploy log https://app.netlify.com/sites/lumeland/deploys/65cc9c25cda28e0008c0acb2
Deploy Preview https://deploy-preview-109--lumeland.netlify.app/docs/overview/installation
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

oscarotero commented 5 months ago

Thanks!

According to the README.md in the repo, it needs --allow-env too:

deno install --allow-run --allow-env --allow-read --name lume --force --reload https://deno.land/x/lume_cli/mod.ts

Could you update the command before merging?

mash-graz commented 5 months ago

I didn't get a warning because of the missing --allow-env, but i'll add it.

oscarotero commented 5 months ago

It was required for npm packages: https://github.com/lumeland/cli/compare/v1.0.1...v1.0.2 Maybe it's not longer required?