search

lumeland / lume

🔥 Static site generator for Deno 🦕
https://lume.land
MIT License
1.88k stars 86 forks source link

Split core functionality in `mod.ts` #535

Closed scarf005 closed 10 months ago

scarf005 commented 10 months ago

Enter your suggestions in details:

currently many features are packed into lume/mod.ts.

  1. getOptionsFromCli is private.
  2. lume uses predefined plugins.
  3. ignorelist is private inside function body,

it may be beneficial to extract these features into separate files. for example, it would make creating an lightweight lume function without pre-defined modules (url, json, vento, etc...) with Cli support easier.

oscarotero commented 10 months ago

I guess getOptionsFromCli() can be moved to core/utils/ folder. What do you think? Do you want to work on a PR?

scarf005 commented 10 months ago

yes, i'll open a PR.