598 feed plugin image support

lumeland / lume

🔥 Static site generator for Deno 🦕

https://lume.land

MIT License

1.75k stars 74 forks source link

598 feed plugin image support #599

Closed negrel closed 2 months ago

negrel commented 2 months ago

Description

Add image support to feed plugin.

Related Issues

Addresses #598.

Check List

[ ] Have you read the CODE OF CONDUCT
[x] Have you read the document CONTRIBUTING
- [x] One pull request per feature. If you want to do more than one thing, send multiple pull request.
- [x] Write tests.
- [x] Run deno fmt to fix the code format before commit.
- [x] Document any change in the CHANGELOG.md.

oscarotero commented 2 months ago

Thanks. The tests are failing due the new image file in the assets folder. Can you run deno task test tests/feed.test.ts -- --update to update it?

negrel commented 2 months ago

Thanks. The tests are failing due the new image file in the assets folder. Can you run deno task test tests/feed.test.ts -- --update to update it?

It seems that my change to test site also impacted snapshot of other tests. I've updated snapshot of those test in a separate commit. I can't run test suite locally, favicon test seems to never end so some failing test may remain. Let me know if that's the case.

oscarotero commented 2 months ago

The favicon issue is a bug from Deno in its support for NPM packages (https://github.com/denoland/deno/issues/21686)

I'm using Deno 1.38.5 to run the tests because it's the most recent version without this bug. You can run deno upgrade --version 1.38.5 to update the tests. Then back to the latest Deno version with deno upgrade.

negrel commented 2 months ago

Should be ok now.

oscarotero commented 2 months ago

Thank you!