search

lumenlearning / candela-citation

Citations for Candela
MIT License
5 stars 4 forks source link

Fix wp-json, fix citations being imported as false #8

Closed dac514 closed 5 years ago

dac514 commented 5 years ago

This patch:

SteelWagstaff commented 5 years ago

Hey @monkecheese -- we're working on a PB core version of attributions (as discussed via email a few weeks ago). This PR would help us make good progress on that work.

ghost commented 5 years ago

This looks really good, though this does not appear to expose the candela citation metadata on the API from what I can tell. Current version of PB is 5.5.6, and the endpoint I tested was:

mysite.com/wp-json/pressbooks/v2/books/<book-id>

dac514 commented 5 years ago

It's going to be in mysite.com/mybook/wp-json/pressbooks/v2/chapters/999 under the meta node.

ghost commented 5 years ago

Alas, there it is! Nice work @connerbw. Happy to merge.

bessfernandez commented 5 years ago

Thanks so much for this patch @connerbw and all! ✨

SteelWagstaff commented 5 years ago

@monkecheese and @bessfernandez, I'm quite sure you've got more than enough other work going on, but I was wondering if you had any idea about if/when you think this PR might be applied to the Lumen production networks? We've confirmed that it works locally with new books created using Candela Citations created with the plugin, but it would be interesting to see how it works with books from some of the various Lumen libraries as well.

ghost commented 5 years ago

For sure! @SteelWagstaff, I have created a ticket and added it as a discussion topic for Sprint grooming and planning. Pending how that goes and any other priorities that might bubble up, I anticipate being able to ship this to our production stack in the next two weeks.

SteelWagstaff commented 5 years ago

Sounds great. We'll keep an eye out for notifications on this thread or occasionally spot check the WP-JSON in one of the Lumen books that uses citations. Thanks!

ghost commented 5 years ago

@SteelWagstaff, we are working toward getting this fix out. I've done some testing around it and it's looking good. I'm hoping for some time this sprint. Thanks for your patience and will let you know here when it's out.

ghost commented 5 years ago

@SteelWagstaff this has now been deployed to production. Cheers!

SteelWagstaff commented 5 years ago

Thanks for the update @monkecheese! We're looking forward to testing it, and will let you know if/when we release a core feature that allows users to provide textual attributions -- if possible, I'd like to see us make it backward compatible with what you're already using.