Closed nithinphilips closed 3 years ago
@victor-soloviev @LeonidKrutovsky can you please review this?
Closed/reopened to run checks
Shouldn't this also have serialize_attributes
for union as well?
So the logs for this have been discarded because the CI run is so long ago now, but I checked it out locally to see what the error was. It's this:
error[E0046]: not all trait items implemented, missing: `serialize_attributes`
--> xsd-parser/src/tests/union/expected.rs:1:28
|
1 | #[derive(PartialEq, Debug, UtilsUnionSerDe)]
| ^^^^^^^^^^^^^^^ missing `serialize_attributes` in implementation
|
= note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)
= help: implement the missing item: `fn serialize_attributes(&self, _: std::vec::Vec<xml::attribute::OwnedAttribute>, _: xml::namespace::Namespace) -> std::result::Result<(std::vec::Vec<xml::attribute::OwnedAttribute>, xml::namespace::Namespace), std::string::String> { todo!() }`
@nithinphilips are you still interested in finishing this?
Closing this because of missing feedback, but I'll still probably integrate all of the changes from here via new PRs. A (broader) dependency upgrade is in #113, and I'll look into the other change afterwards.
serialize_attributes
method for YaSerialize in the UtilsDefaultSerde macro.getRecordDataHeaders
) which is inadvertently converted to upperCamelCase (GetRecordDataHeaders
) because of the struct name conversion. Use yaserde 0.4 support forrename
in struct attributes to preserve the name from the XSD/WSDL.This will require projects using this library to upgrade to yaserde 0.4. No code changes should be required if they do not manually implement
YaSerialize
.