lumeohq / xsd-parser-rs

A xsd/wsdl => rust code generator written in rust
Apache License 2.0
96 stars 34 forks source link

Update to yaserde 0.4 and implement rename on structs #104

Closed nithinphilips closed 3 years ago

nithinphilips commented 4 years ago

This will require projects using this library to upgrade to yaserde 0.4. No code changes should be required if they do not manually implement YaSerialize.

chrisabruce commented 4 years ago

@victor-soloviev @LeonidKrutovsky can you please review this?

DmitrySamoylov commented 4 years ago

Closed/reopened to run checks

RoastVeg commented 3 years ago

Shouldn't this also have serialize_attributes for union as well?

jplatte commented 3 years ago

So the logs for this have been discarded because the CI run is so long ago now, but I checked it out locally to see what the error was. It's this:

error[E0046]: not all trait items implemented, missing: `serialize_attributes`
 --> xsd-parser/src/tests/union/expected.rs:1:28
  |
1 | #[derive(PartialEq, Debug, UtilsUnionSerDe)]
  |                            ^^^^^^^^^^^^^^^ missing `serialize_attributes` in implementation
  |
  = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)
  = help: implement the missing item: `fn serialize_attributes(&self, _: std::vec::Vec<xml::attribute::OwnedAttribute>, _: xml::namespace::Namespace) -> std::result::Result<(std::vec::Vec<xml::attribute::OwnedAttribute>, xml::namespace::Namespace), std::string::String> { todo!() }`

@nithinphilips are you still interested in finishing this?

jplatte commented 3 years ago

Closing this because of missing feedback, but I'll still probably integrate all of the changes from here via new PRs. A (broader) dependency upgrade is in #113, and I'll look into the other change afterwards.