search

lumien231 / Bloodmoon

The source code for the Bloodmoon Mod
23 stars 27 forks source link

Incompatibility with Astral Sorcery #18

Closed Sunconure11 closed 6 years ago

Sunconure11 commented 7 years ago

https://github.com/HellFirePvP/AstralSorcery/issues/116

"that's why AS is incompatible with bloodmoon - lumien ASM's the renderSky method to add his moon colorization hook - which is a terrible implementation. to recolor sun/moon you don't need ASM at all. tl;dr his implementation is terrible and doesn't care if other mods change the sky. if he had implemented it properly, compatibility would be no issue"

lumien231 commented 7 years ago

Wow what a nice message :). I'll see what i can do, i can probably change the moon texture directly instead of modifying its color when it's drawn.

HellishINC commented 7 years ago

I'm guessing that if you replace the texture, resource packs will also have to provide a blood moon'd texture?

lumien231 commented 7 years ago

No, i'll just modify the texture on the fly. It will use the moon texture of the active resource pack.

FireController1847 commented 6 years ago

I can confirm this issue, and hope it gets fixed soon.

FireController1847 commented 6 years ago

Eventually™

darchitectlp commented 6 years ago

Any word on this? Love me some red light on a bloodmoon... I'm also getting a weird yellow tint when I use night vision, and I'm having a hard time tracking down what's causing it.

ate0ate commented 6 years ago

Geeze, this sure would be a great little bit of mod integration to have but I gotta agree with Lumien about the original message. Not exactly the most pleasant way to go about pointing out the issue lol.

FireController1847 commented 6 years ago

Huzzah!