search

lumien231 / Hardcore-Darkness

Minecraft mod that removes minimum light
17 stars 15 forks source link

Add support for the Calendar API #13

Closed Sunconure11 closed 8 years ago

Sunconure11 commented 8 years ago

https://github.com/CallMeFoxie/Calendar/tree/1.7.10

This API cropped up recently, and I suggest you check it out for 1.7.10 and 1.8 builds of your mod, so lighting based on the moon cycle can be in sync with other mods that use it, or plan to use it (Stellar Skies, due to its longer lunar cycle, would be a good example)

lumien231 commented 8 years ago

I don't use any time related methods in HardcoreDarkness, if mods like these don't patch vanilla methods so that they retain their meaning (Getting the moonphase) i can't really do anything about that.

Sunconure11 commented 8 years ago

Alright. Is there a way I can get your mod to work better with Stellar Sky (regarding light changing with the phases of the moon), or am I going to have to see if the dev of Stellar Sky can do that?

PitchBright commented 8 years ago

@Sunconure11 There's nothing the end-user can do to make the two mods work together. HardcoreDarkness calls info from a method getCurrentMoonPhaseFactorBody() in the World class for it's Moon Phase info, and StellarSky uses a method getMoonPhase() in the WorldProvider class.

I think there's differing opinions on which one is the correct one to use.

lumien231 commented 8 years ago

I expect vanilla methods to work how they do in vanilla.