lumien231 / Random-Things

The Random Things Minecraft Mod
69 stars 42 forks source link

Update RenderUtils.java #450

Open ben-mkiv opened 5 years ago

ben-mkiv commented 5 years ago

This PR addresses an issue which i ran into when using RandomThings (might be related to OpenTerrainGenerator or JustEnoughIDs)

I'm not sure if this is the best way to fix it as im not familiar with biome related stuff

The amount of changed lines is due to that i've moved some duplicated code to a separate function call, the main logic change is on the linked line, which checks if the biome has any type assigned before manipulating the biome color based on the biome type

https://github.com/lumien231/Random-Things/blob/8235fa7574699d4b5ccff16aa62c79379274cadd/src/main/java/lumien/randomthings/util/client/RenderUtils.java#L113

crash report of rendering a cable facade with biome stone in JEI https://pastebin.com/raw/NiiSjdWx