lumien231 / Random-Things

The Random Things Minecraft Mod
69 stars 42 forks source link

Hacky Bottle of Air Reflection #495

Open Yslohr opened 4 years ago

Yslohr commented 4 years ago

https://github.com/lumien231/Random-Things/blob/27c32df89682325d2fe6a95032892645b2c259de/src/main/java/lumien/randomthings/item/ItemBottleOfAir.java#L19-L36 This section seems extremely hacky. It has been making the already unstable forge development environment more unstable when you use random things as a dependency. These names should be provided by the Forge API (FMLDeobfuscatingRemapper etc...) Keep in mind, this is with the VM argument "-Dfml.coreMods.load=lumien.randomthings.asm.LoadingPlugin" while having my mcp mappings (stable_39) in a folder called "mcp" at the root of the mod project. Forge version is 14.23.5.2854 for Minecraft 1.12.2 and using ForgeGradle 3.+